tor2web/Tor2web

Banner should ignore ">" in quotations.

cheako opened this issue · 3 comments

cheako commented

Most browsers process ">" as part of an attribute's value. Tor2web currently injects the banner just after such a token.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

evilaliv3 commented

thanks @cheako could you elaborate around this issue and eventually prepare a pull request for addressing it?

cheako commented

I'm unable to understand where it is that the trailing ">" is located and how the banner is injected. I discovered the issue doing some testing while building design requirements. I feel the current behaviour should be corrected. Take for example the following.

<body id="foo>bar">

Currently Tor2web inserts the banner in front of bar. If I'm to reimplement this I'd change the behavior so the banner is injected after the '">'.

cheako commented

I have other questions regarding design specifications what would be the best forum to ask these? I wonder about the compression code I've seen, where this comes into play. I also wonder about https over for, if this is attempted or not?