grapple vs wagtail-grapple
dopry opened this issue · 14 comments
Initially I foundy myself confused by the difference between grapple and wagtail grapple. I had to pip install wagtail-grapple, but then import grapple in my code. It would be nice if the package only had one canonical name.
I think it's good actually, it improves the developer's understanding of the matter and since there are tons of material for graphene, finding help is going to be nicer for them
@engAmirEng are you saying you feel two canonical names helps developers, or that you would prefer grapple as the canonical name?
@dopry Oh shoot, sorry, I miss wrote grapple instead of graphene, I meant there are tons of online material in the title of graphene plus I think referencing the standard graphene classes and attrs in the grapple name space just for the sake of naming just sounds wrong
I'm not proposing changing the name altogether and grapple is not graphene by a long shot. There is a lot of behavior baked in above and beyond graphene. The only thing I'm proposing is choosing one of grapple or wagtail-grapple to refer to the package instead of using both.
we cannot refer to the package as grapple outside of imports. e.g. https://pypi.org/project/grapple/ is taken by a crypto-related package.
I don't see a massive issue with calling the package wagtail-grapple, but import from grapple. There are plenty of Python/Django precendents (e.g. python-dateutil). Granted, I may be biased :D
the existence of https://pypi.org/project/grapple/ should be reason enough to update the namespace to wagtail_grapple. The moment someone wants to use wagtail_grapple and grapple in the same project there will be a problem. . It's just good manners not to use a namespace someone else has already reserved.
On one hand it is a tricky one as it will introduce quite the breaking change which I am not sure I necessarily want to push onto other developers (imports, settings etc). At least not yet
On the other hand it would be explicitly wagtail_grapple.
Would love to hear other people's thoughts
Not sure if I get a vote but I'm with @dopry
Just because @tinybike hasn't made a release in 8 years doesn't mean they don't have the rightful claim on the namespace. If we want to continue to use the namespace, maybe we should reach out to @tinybike and ask? Ultimately we have no control over what @tinybike wants to do and no right to usurp a namespace he registered with pypi before wagtail-grapple existed.