File mode specification error and post-command-hook error due to missing minor mode declaration

[abradd]

Hi,

I'm running Emacs 27.1.91. I'm running org-super-links version bba93e8.

I have installed org-super-links through straight with:

(use-package org-super-links
  :straight (org-super-links :type git :repo "toshism/org-super-links" :host github :branch "develop")
  :hook org-mode)

and tested it with just use-package:

(use-package org-super-links
  :hook org-mode
  :load-path "~/.emacs.d/straight/repos/org-super-links/")

When entering an org file I see an error:

File mode specification error: (error Autoloading file ~/.emacs.d/straight/repos/org-super-links/org-super-links.el failed to define function org-super-links

and when attempting to run a command on an org file such as org-add-note the command doesn't complete with:

Error in post-command-hook (org-add-log-note): (error "Autoloading file ~/.emacs.d/straight/repos/org-super-links/org-super-links.el failed to define function org-super-links")

I noticed define-minor-mode isn't defined in org-super-links.el. Defining it as:

(define-minor-mode org-super-links
  "org-super-links minor mode")

resolves the above issues. I don't actually know if defining a minor/major mode is required alongside the provide. I wasn't able to find any documentation that told me explicitly. Is there something I'm missing?

Cheers

[abradd]

I found the issue. I should not be using :hook in my configuration of this package as it attempts to run the function org-super-links which doesn't exist. Sorry for the noise.