Request to update "default_root"

Question

Request to update "default_root"

KangGeunSu opened this issue 3 years ago · 12 comments

KangGeunSu commented 3 years ago

I made an example using totaljs(git)/example/authorization.
example.zip

Common fixes

./views/homepage.html

<script src="https://cdn.componentator.com/spa.min@17.js"></script>
-> <script src="/js/spa.min@17.js"></script>
<link rel="stylesheet" href="//cdn.componentator.com/spa.min@17.css" />
-> <link rel="stylesheet" href="/css/spa.min@17.css" />
add
-> <script src="/js/ui.js"></script>
-> <link rel="stylesheet" href="/css/ui.css" />

File add

./public/js/
-> spa.min@17.js
-> ui.js

./public/css/
-> spa.min@17.css
-> ui.css

Compare two files

example.zip/authorization

-> total4 original

example.zip/authorization_rw

-> node_modules/total4/utils.js

const REG_URLEXT = /(https|http|wss|ws|file):\/\/|\/\/[a-z0-9]|[a-z]:|@\{|/i; (Line 96)
-> const REG_URLEXT = /(https|http|wss|ws|file):\/\/|\/\/[a-z0-9]|[a-z]:/i;
return REG_URLEXT.test(text) ? text : ((text[0] === 'h' ? 'href' : 'src') + '="' + CONF.default_root + (text[pos] === '/' ? text.substring(pos + 1) : text)); (Line 2551)
-> return REG_URLEXT.test(text) ? text : ((text[0] === 'h' ? 'href' : 'src') + '="' + CONF.default_root + (text[pos] === '/' ? text.substring(pos + 1) : text.substring(pos)));

config

name					: Total.js Auth example

default_root				: /total

// IMPORTANT SETTINGS:
cookie		(generate)	: 10
cookie_secret	(generate)  	: 10

Issues

example.zip/authorization

-> Call http://localhost:8000/css/spa.min@17.css
-> No "default_root" when calling "js" or "css".

example.zip/authorization_rw

-> Call http://localhost:8000/total/css/spa.min@17.css
-> There is a "default_root" when calling "js" or "css".

Please help me to use "default_root"
Thank you

Answer 1 · 2021-08-25T06:26:41.000Z

Thank you so much.
Please try it now: $ npm install total4@beta. I have improved the functionality.

Answer 2 · 2021-08-27T04:38:51.000Z

Tested after confirmation.

Hmm....

example.zip/authorization_rw

-> node_modules/total4/utils.js
return REG_URLEXT.test(text) ? text : ((text[0] === 'h' ? 'href' : 'src') + '="' + CONF.default_root + (text[pos] === '/' ? text.substring(pos + 1) : text)); (Line 2551)

Can't I just change this part?

return REG_URLEXT.test(text) ? text : ((text[0] === 'h' ? 'href' : 'src') + '="' + CONF.default_root + (text[pos] === '/' ? text.substring(pos + 1) : text));

Because 'text' is appended with 'href or src' at the end.

Sorry for my lack of explanation.

Answer 3 · 2021-08-27T06:24:45.000Z

I have changed the functionality to this:

function $urlremap(text) {
	var pos = text[0] === 'h' ? 6 : 5;
	var url = text.substring(pos, text.length - 1);
	return REG_URLEXT.test(url) ? text : ((text[0] === 'h' ? 'href' : 'src') + '="' + CONF.default_root + (text[pos] === '/' ? text.substring(pos + 1) : text));
}

The current functionality is good. text contains the entire value from the src or href attribute with the attribute name. So first, the method parsers url if it's able to be modified. If yes, then then it changes if by adding a root value from the config. If no, then returns unchanged text.

Answer 4 · 2021-08-27T09:05:57.000Z

If no, returning unaltered text results in 2 "href or src" due to preceding "((text[0] === 'h' ? 'href' : 'src') + '=".

Answer 5 · 2021-08-27T09:07:14.000Z

Can you create a small example with that problem? Just download emptyproject and try to simulate the problem. I need to debug it.

Answer 6 · 2021-08-27T09:42:58.000Z

Can't make it right now...

I can't remember what was inappropriate for const REG_URLEXT = /^(https|http|wss|ws|file):\/\/|\/\/[a-z0-9]|[a-z]:|javascript:|#|@\{|'|"|\(/i;...

const REG_URLEXT = /(https|http|wss|ws|file):\/\/|\/\/[a-z0-9]|[a-z]:/i; is possible, is that ok?

With the example above, we will make the best example.

I like flow!!

Answer 7 · 2021-08-27T09:48:46.000Z

const REG_URLEXT = /(https|http|wss|ws|file):\/\/|\/\/[a-z0-9]|[a-z]:/i; this is not possible to use because that RegExp rewrites links below:

<a href="javascript:something()">
<a href="#home">
<a href="@{url}">

var str = '<a href="' + str + '">';

and that's not good.

Answer 8 · 2021-08-27T09:48:57.000Z

If you have any problematic example, then send me it.

Answer 9 · 2021-08-30T01:14:18.000Z

I checked it over the weekend.

I mostly write FLOW.
I wanted it to be "default_root" in "FLOW"

As a result, now seems to be the case.

It seems appropriate to modify the flow in the current state.

I will try more FLOW and reopen in FLOW.

Thank you very much.

Answer 10 · 2021-08-30T02:10:35.000Z

How are you planning to do this?

var str = '<image width="150" height="150" xlink:href="{0}img/theme{1}.png" />'.format(url, common.theme || 'white'));

Answer 11 · 2021-08-30T11:19:08.000Z

Yes, there was a bug with xlink:href - I forgot on this type of attribute.

updated Total.js 4 beta version npm install total4@beta
download again flow.package https://github.com/totaljs/emptyproject-flow
set default_root e.g. to /subflow/
run it
then let me know

Answer 12 · 2021-08-31T01:00:04.000Z

Has confirmed

you are the best!!

The background didn't work either, so I tried to edit it a bit, but you solved it all at once.

It's really great!

Thank you always