No images in Calendar Mode
Yp-pro opened this issue · 15 comments
Hello,
Good job! I like your Log Viewer more than the native one.
But I've got an issue with Calendar Mode:
When I click on a date (pink bar) the Viewer doesn't show images and says "No images" but there are many ones in this folder and the native log shows them.
Windows 10 Pro, Chrome. Other browsers - the same situation
Hi
Thanks
It seems linked to this issue (with a proposal of fix)
#13
Can you confirm ?
I will merge the fix (even if I cannot reproduce because of international date format display)
Sure, thank you
New release is published with fix
Sorry, but it doesn't work.
Here's the Calendar Mode:
I checked it in the regular mode, the same issue:
Of course, there're many images in that folder:
And the native log shows it:
I tryed it in Chrome and Firefox. No difference.
Sure, I deleted the old files and unzipped the new ones (1.5.2). Fooocus was closed and opened again after update, as you have mentioned. No difference.
Somewhere it works well:
I have a clue. All images that I can see are PNG. I can't see JPG. Is it important?
I think .jpg extension could be the reason
Fooocus generates .png
How do you have .jpg ?
I think .jpg extension could be the reason Fooocus generates .png How do you have .jpg ?
Converted them with IrfanView for saving the space on the disc (I generate a lot)
And you change the name in log.html at the same time ?
Not name, just an extension
yes, you're right, but is the extension changed every where in log.html (not only where it is viewable in browser)
I just do Find/Replace and change all "png" to "jpg" in log.html. Everything works well after that (except your Viewer)
Log.html is not used by Fooocus itself.
I will check if I am looking for .png file or the exact full name that is stored in log.html
thanx
It seems like I found the problem. Look:
- When I generate as usual (PNG), everything is okay:
- If I convert these images to JPG (without changing log.html) I see the following:
and see nothing if I open log.html in a browser:
- Important! If I do Find/Replace in log.html and replace every "png" there, your Viewer won't show these images.
- Important! If I rename only image extensions, your Viewer works well:
Wrap up:
It's very important not to change the div id in this part, only the image extensions. The div id should always end with "_png".:
<div id="2024-02-17_20-30-34_5910_png" class="image-container"><hr><table><tr>
<td><a href="2024-02-17_20-30-34_5910.png" target="_blank"><img src='2024-02-17_20-30-34_5910.png' onerror="this.closest('.image-container').style.display='none';" loading='lazy'></img></a><div>2024-02-17_20-30-34_5910.png
It brokes evertything.
- It would be great if you fixed that somehow
Well done buddy !
I will try to fix the div#id content to be ok with _png or _jpg