Compilation error due to variable used uninitialized
casantos opened this issue · 3 comments
Some inline declarations of strtok_r (specifically in Sourcery CodeBench Lite 2016.11-19) contain code where an '__s' local variable can be used uninitialized.
When GCC expands that declaration in 'parse_pcrs', __s becomes an alias to the local variable 'saveptr', which in fact is not initialized, but this is not relevant, since the 'str' argument is knowingly not NULL when passed to strtok_r because it comes from 'optarg' in parse_opts.
Anyway, applying the attached patch to initialize saveptr to NULL prevents the compilation error.
Fixes: http://autobuild.buildroot.net/results/5693a35e4d6bc76a1f46fe0e217abc49f7188aad/
Compilers are weird... Thank you for the patch, LGTM!
@casantos I just released v0.1.2-rc1 including your fix: https://github.com/tpm2-software/tpm2-totp/releases/tag/v0.1.2-rc1
If that works for you, I can release the final v0.1.2 tomorrow and you can update your build recipe.
@casantos I just released v0.1.2-rc1 including your fix: https://github.com/tpm2-software/tpm2-totp/releases/tag/v0.1.2-rc1
If that works for you, I can release the final v0.1.2 tomorrow and you can update your build recipe.
I tested it on Buildroot ad it works. Thanks!