tr7zw/EntityCulling

[BUG] Fabric version depend on Fabric API but doesn't declare it in FMJ

Closed this issue · 5 comments

I was testing things for another bug and narrowed it down to potentially be caused by EntityCulling
so i tried to remove all mods but it since it doesn't have any dependencies and launch the game
however this did produce a crashlog
by reading lines 25 and 31, you can easily see that the mod tries to call some code from the fabric API, but doesn't succeed

25: Caused by: java.lang.NoClassDefFoundError: net/fabricmc/fabric/api/client/event/lifecycle/v1/ClientTickEvents
31: Caused by: java.lang.ClassNotFoundException: net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents

this is due to the code right here

ClientTickEvents.START_WORLD_TICK.register((event) -> {
this.worldTick();
});
ClientTickEvents.START_CLIENT_TICK.register(e -> {
this.clientTick();
});

tr7zw commented

Hm true, will fix that next release. I keep forgetting that, as the CurseForge launcher installs the Fabric API by default anyway.

Hm true, will fix that next release. I keep forgetting that, as the CurseForge launcher installs the Fabric API by default anyway.

OOF truly a CursedForge moment

tr7zw commented

Without them, none of my mods would be a thing... sooo^^
But yea, starting fabric without the API is usually never correct.

tr7zw commented

God, this issue caused so many issues.

Closing as this has been fixed. But jeez this caused soooo many follow up issues.