tr7zw/ItemSwapper

Request: This mod for Forge 1.16.5

Maya1924 opened this issue · 6 comments

Is your feature request related to a problem?

No

Describe the solution you'd like

I'm playing Enigmatica 6 Expert. I love this mod, but E6E is forge and 1.16.5. Just thought I'd put in a request for it!

Describe alternatives you've considered

No response

Additional context

No response

tr7zw commented

Probably no. A forge version some time later, but then 1.20 and 1.19.4.

Probably no. A forge version some time later, but then 1.20 and 1.19.4.

instead of making another issue thread ill just ask here, could u port it to 1.16.5 fabric maybe?

tr7zw commented

Probably no. A forge version some time later, but then 1.20 and 1.19.4.

instead of making another issue thread ill just ask here, could u port it to 1.16.5 fabric maybe?

Same issue as Forge 1.16. It would require a major amount of work for which I don't have the time right now(or much interest in, as I don't play old versions). If someone feels adventurous, feel free to try to create a PR, but to port it back to 1.16 you have to get through a lot of stuff like Java 17 -> Java 8(so removing all instance of switches/records) and the old screen system. The only good starting point would be the 1.18 backported version.

tr7zw commented

Out of curiosity, tried compiling the 1.18 source against 1.16, and it mainly failed at the Java 17->8 issues (20 errors). So potentially it's actually not too bad?

tr7zw commented

Ok yea, main issues:
RenderSystem Shader/setShaderTexture are gone
The logic around accessing the shulker content is gone/renamed?
The network packets identifier and data are private without a getter, so you can't access them without breaking it open?!?
So neither the rendering nor shulkers will work without having to do a deep dive into which magic numbers/methods need to be used in 1.16.