tractorcow/silverstripe-opengraph

php 5.2 incompatible

Closed this issue · 2 comments

in OpenGraph.php Line 65

$class = self::$siteconfig_extension_class;
$class::$application_id = $applicationID;

is 5.3 only

well i am not a fan of servers that still run 5.2 but sometimes there is no choice

whats the benefit of:

$class = self::$siteconfig_extension_class;

I had some code left over from some shoddy refactoring.

The intent was that user code could extend the OpenGraphSiteConfigExtension class if they wanted to override the behaviour in a subclass, and tell the module to use their class instead.

This really should not have been applied to static members (as subclasses can still access the static members of OpenGraphSiteConfigExtension).

Will un-engineer this shortly. :)

The above issue is fixed in the latest update.