decouple indexing from createMV in indexers

Question

decouple indexing from createMV in indexers

peterg17 opened this issue 6 years ago · 3 comments

Essentially, because 3D indexing adds to the same table between canvases, I had trouble where the createMV function would overwrite the same index for each canvas. I solved this by building a workaround where I made a separate function for just the 3D rtree indexer, but I think that we should decouple the indexing from the other operations in createMV so this is more clean and well done. I understand this issue and can do it.

Answer 1 · 2019-04-22T16:58:03.000Z

I'd like to learn more - I'm also making big changes to createMV. Perhaps the 3D index could be created after the per-layer indexes? Anyway, the sooner I can see code the better: I'll be working to parallelize this across the cluster. Adam (via cellphone, random spelling ahead)

…

On Mon, Apr 22, 2019, 12:14 PM peterg17 ***@***.***> wrote: Essentially, because 3D indexing adds to the same table between canvases, I had trouble where the createMV function would overwrite the same index for each canvas. I solved this by building a workaround where I made a separate function for just the 3D rtree indexer, but I think that we should decouple the indexing from the other operations in createMV so this is more clean and well done. I understand this issue and can do it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#71>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCFYQ3WC5M3IAQ3PXTFZ3PRXP45ANCNFSM4HHQX6UQ> .

Answer 2 · 2019-04-22T20:34:02.000Z

sorry, I can't quite understand what the issue is.

createMV() is called per layer. As we talked, you can still follow this by only create table/index for layers that are not on the top-level, similar to what I did for my autoDDIndexer

Is this what this issue is about?

Answer 3 · 2019-04-26T16:49:58.000Z

@peterg17 per discussion yesterday, we will find ways to infer whether a canvas is on the top/bottom level, to help decide whether to create index for this canvas. This will keep the current structure (i.e. indexing is still done in createMV).