docker scripts hardcode port number

Question

docker scripts hardcode port number

tracyhenry opened this issue 5 years ago · 2 comments

should be read from config

Answer 1 · 2019-07-26T20:42:35.000Z

I'm guessing this is to avoid port conflicts... Presumably, you mean the port number in the host OS, not the internal-to-vm port number... I.e. trivial fix to the docker startup scripts. Primarily affects developers - staging/prod will use dedicated instances where there won't be port conflicts...

…

On Fri, Jul 26, 2019, 11:30 AM Wenbo Tao ***@***.***> wrote: should be read from config — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#94?email_source=notifications&email_token=AABCFYXZMJSD5QZZV4P6ZNLQBMKBVA5CNFSM4IHE42VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBXYHAQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCFYU7TDBR7OSFWO5C66TQBMKBVANCNFSM4IHE42VA> .

Answer 2 · 2019-07-26T21:03:35.000Z

I'm guessing this is to avoid port conflicts... Presumably, you mean the port number in the host OS, not the internal-to-vm port number... I.e. trivial fix to the docker startup scripts. Primarily affects developers - staging/prod will use dedicated instances where there won't be port conflicts...
…
On Fri, Jul 26, 2019, 11:30 AM Wenbo Tao @.***> wrote: should be read from config — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#94?email_source=notifications&email_token=AABCFYXZMJSD5QZZV4P6ZNLQBMKBVA5CNFSM4IHE42VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBXYHAQ>, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCFYU7TDBR7OSFWO5C66TQBMKBVANCNFSM4IHE42VA .

yes.