traefik/faency

V4 release is not compatible with jest tests

seedy opened this issue · 1 comments

seedy commented

Description

V4 release changes bundling

Running jest unit tests - without transformations - with components importing this package now break with following error:

 ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    node_modules/@traefiklabs/faency/dist/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){export { AccordionContent, AccordionItem, AccordionRoot, AccordionTrigger } from './components/Accordion/Accordion.js';
                                                                                      ^^^^^^

    SyntaxError: Unexpected token 'export'

    > 1 | import { Button } from '@traefiklabs/faency'

Investigation

Jest is not able to handle es modules properly:

Previously, we exported a cjs version of the package.

In an attempt to improve bundling and tree-shaking, it was removed.

Could we put back cjs packaging and choose the esm module by default and only the cjs one for unit testing?

traefiker commented

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀