Suggestion - Improve Dart Colours
aedwardg opened this issue · 7 comments
Hi @trallard,
What do you think about the current Dart colors?
To me they don't seem to align as well with the theme as other languages. There is a lot of yellow. It looks like all the class names are yellow and strings are all showing up as the periwinkle color: #7998F2. There are a few other inconsistencies, but those are the big ones that stand out right away.
If you think this is something worth fixing, I'm willing to help out.
hey @aedwardg thanks for raising this! I personally do not use Dart but I do agree this does not align with most of the theme approach.
I have a couple of thoughts here:
- too much yellow - will perhaps need to balance out with the soft pink
- strings -> will need to match with the overall light turquoise for the theme
- classes are currently yellow -> should be periwinkle
Since I am not a Dart user, would you be happy to work together in this? I certainly would appreciate having the input from someone who does use Dart and make sure the theme also has a consistent look and feel
Sounds good. I'm definitely willing to collaborate on this. I was surprised to see that the coloring was so different from JavaScript, since many aspects of Dart seem to be a hybrid of Java and JavaScript.
interesting 🤔 for JavaScript I used Night Owl as a strong reference will also check how it compares for Dart.
I had a similar issue when working with Arm templates - they're basically JSON but the highlighting was so different so I had to do some scope digging
To get started with the PR - would you be able to add a sample Dart script in the /tests directory? I can then start doing some comparisons and we can then move onto scope matching/updating
Sure, no problem.
Anything specific I should include to cover the bases?
@trallard I went ahead and PRed some samples for both regular Dart and Dart as it is used with Flutter, since the two differ somewhat.
Just for fun, the Flutter sample is actually the code for a Pitaya Smoothie demo app that I deployed to the web 😂:
https://aedwardg.github.io/pitaya-smoothie-demo/#/