transmissions11/solmate

ERC1155U/ERC1155D

transmissions11 opened this issue · 2 comments

PraneshASP commented

Hi @transmissions11 not sure if this is the correct place for this discussion.

Just curios to know why the isApprovedForAll check is ignored in the burn() method of the Solmate's ERC1155 library. Is it due to the reason that the validation can be done in the implementing contract? or is it safe to ignore the check completely?

1) Contract: ERC1155Burnable
       burn
         unapproved accounts cannot burn the holder's tokens:
     AssertionError: Expected an exception but none was received

Because the testcases(based on OZ tests) are being reverted at the burn and batchBurn methods. Fixed the above issue by adding the validation in the implementing contract, but just wanted to check this with you as well.

Kindly advise.

Cheers!

transmissions11 commented

its an internal burn function, if the developer wishes to expose a public burn they must implement that behavior themselves

  • 👍1