transmissions11/solmate

token interfaces

z0r0z opened this issue · 4 comments

z0r0z commented

IERC ... 20, 721, 1155

transmissions11 commented

dont like interfaces, just use the contract

mds1 commented

But then the whole contract shows up on Etherscan / in a flattened version, when really you're just using an interface, making it harder to read cause there's a bunch of unused code 😅

transmissions11 commented

lol i hate being a position of power against friends who i disagree with, feels so dirty

but my honest thoughts are:

  • thats not really worth optimizing for
  • if it is something you care about, use multi file verification
  • 👍1
  • ❤️1
mds1 commented

I think it's fine to leave solmate as-is/opinionated but saw the tweets and had to back up @z0r0z 😛

These are valid counters though. In general I'm torn about whether optimizing for the Etherscan UI is worth it (nat spec, contract verification, etc.), because in principle I agree you shouldn't, but in reality it's how a lot of people interact with/view contracts