traversc/qs

Suggestion : default parameter nthread

Closed this issue · 2 comments

BenjaminDEMAILLE commented

Hi !
is it possible in a future version to do in default

nthreads = parallel::detectCores()

thanks

traversc commented

My preference is to keep the default as 1, but this could be an option:

options(qs.nthreads = 4)

qsave <- function(..., nthreads = getOption("qs.nthreads", 1L)) {
  ...
}

Does that work?

  • 👍1
HenrikBengtsson commented

I downvote the feature request for nthreads = parallel::detectCores(), and upvote "keep the default as 1", because of several reasons, which I write about in https://www.jottr.org/2022/12/05/avoid-detectcores/.