DESCRIPTION file broken?
Closed this issue · 6 comments
The guys from Posit have found out, that an error in the file will prevent the build of the module for the package manager.
Here are the link for the problem description.
https://community.rstudio.com/t/qs-binary-package-for-r-4-3-and-rhel-9-is-missing/183207/2
Thanks for the link, repsonding in rstudio forum
@barracuda156 I changed the way to check for the -latomic flag because of this issue.
https://github.com/traversc/qs/blob/master/configure.ac#L63
Would it be possible to confirm that the latest commit still works on your system?
@traversc This will not work, AFAIU, since we need to check for 8-byte atomics: using int will check for 4-byte atomics support, which will not need libatomic.
P. S. I am not aware of situations where 4-byte atomics needs libatomic, to be honest. Normally what needs it is 8-byte atomics, which is not supported on a hardware level on 32-bit archs. So that should be checked.
I have seen elsewhere that RISC-V needs to check for 1-byte atomics, but cannot confirm that personally.
Got it, I added all the atomic types used in the package, should work now :)