tree-sitter/tree-sitter-php

Broken tests on master?

calebdw opened this issue · 6 comments

calebdw commented

Hello!

Maybe it's just me, but there are 4 tests currently failing on master. Git bisect shows that @amaanq's commit 6cd93c9 is the culprit (at least for some of the broken tests).

Steps to Reproduce:

I'm using:
Node: v20.8.1
Tree-sitter: 0.20.8

  1. checkout master
  2. npm install
  3. npm run build
  4. npm run test
  5. fail

Running the above commands produces a diff on the generated files which suggests they weren't regenerated after one of the more recent commits.

image

Interestingly, I'm seeing the i flags being removed from the grammar.json which is likely the cause for some of the broken tests...

Tests

Case insensitive keywords

image
image

Readonly properties

image

Capitalized logical operators

image

Associativity of null-coalescence

image

amaanq commented

use tree-sitter master, it supports the regex i flag

  • 👍1
calebdw commented

That would explain it---however, that requirement is not captured in package.json

calebdw commented

What's an easy way to compile/install tree-sitter master?

amaanq commented

yeah node and master are a bit disjunct atm, my hands are tied but I'd like a new release though

cargo install --git https://github.com/tree-sitter/tree-sitter

  • 👍1
calebdw commented

@amaanq, any chance we can get a node release soon?

amaanq commented

soon hopefully

  • 👍1