treebohotels/leaf-ui

Notification "type" prop validator should be one of the predefined types

srinivasdamam opened this issue · 1 comments

srinivasdamam commented

At present <Notification/> has "type" prop validator as string.

Notification.propTypes = {
    type: string
}

It would be good use oneOf validator with predefined types.

Notification.propTypes = {
    type: oneOf(['info', 'success', ...whatever])
}

Shall I raise the PR for this issue?

whilelucky commented

Hey @srinivasdamam!

Thanks for taking the time to find and report this and many other issues, we love self driven people and we most certainly love contributions 🥇

This is a case where everyone can agree that the issue and PR looks great and can be merged immediately after the comments raised on the PR have all been addressed.

However, leaf-ui is in beta mode until it hits v1.0.0, some of these issues and more are currently known and are already being operated on in parallel by others too :) We would appreciate it if you continued to raise issues first but then raise PR's only if it's necessary and agreed upon since leaf-ui represents Treebo's frontend guidelines strongly. This would help all of us concentrate on features and issues without duplicating efforts :)

Really, it's our fault for not having our contribution guidelines up. We will have it up as soon as possible so that everyone can contribute more efficiently 💯