treebohotels/leaf-ui

CSS clip property is deprecated

srinivasdamam opened this issue · 2 comments

There is the mdn link about this.

There are couple of places where clip is used like this.

clip: rect(0,0,0)

Same can be achieved with this.

visibility: hidden

Shall I raise a PR for this?

Hey @srinivasdamam, the visibility: hidden approach unfortunately won't work as intended in this case. Hiding the native checkbox and radio buttons from the browser with this approach no longer let's you use the Tab or Arrow Up / Down keys to navigate between them in focused states.

We require all form inputs to be keyboard navigable, since it's crucial to our accessibility guidelines.

Maybe there's a different way you could approach this while still maintaining keyboard support? We would definitely be open that :)

I updated the PR #27