Add better validation for .mp4 video mode
Closed this issue · 2 comments
himynamesdave commented
Currently there is limited validation for .mp4 files
https://github.com/trek-view/gopro2gsv#validation-1
With introduction of new modes (e.g. #28 ) validation should be stricter
- file extension must be
.mp4
- filenames must start with
GS
orVIDEO_
XMP-GSpherical:ProjectionType
isequirectangular
trackN:MetaFormat
isgpmd
trackN:GPSDateTime
has more than 10 entries
Where trackN
is the track that contains the gpmd telemetry.
fqrious commented
does this mean .mp4
mode should continue to use video->video
pipeline and only .360
mode goes through video->image->video
piepliine?
himynamesdave commented
@fqrious for 360 (or dual mp4 mode) videos the frames are extracted (and created), therefore these frames can be processed per image->video
pipeline. The processing to frames is similar (but not identical to mp4 video mode)
does this mean .mp4 mode should continue to use video->video pipeline
yes. with the changes described here #26