trekawek/coffee-gb

Remove SLF4J-Simple binding

Closed this issue · 3 comments

coffee-gb/pom.xml

Lines 110 to 113 in 9f2ea20

<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>1.7.16</version>
</dependency>

Please remove any concrete SLF4J bindings, such as slf4j-simple from your dependencies. This makes it hard for users of your project to define their own binding, such as log4j2 or similar:

error

This is mainly a problem because your artifacts are fat/uber-jars. So dependency-exclusions dont work. Ideally, a library would never include any concrete bindings but only the facade itself.

Cheers and thanks for this awesome project!

Thanks for the suggestion @Zabuzard! Could you take a look at #21 to see if it makes it better?

Good stuff, thanks 👍

Version with removed binding has been released as 1.0.2.