tremor-rs/tremor-language-server

RUSTSEC-2021-0124: Data race when sending and receiving after closing a `oneshot` channel

github-actions opened this issue · 2 comments

Data race when sending and receiving after closing a oneshot channel

Details
Package tokio
Version 0.2.25
URL tokio-rs/tokio#4225
Date 2021-11-16
Patched versions >=1.8.4, <1.9.0,>=1.13.1
Unaffected versions <0.1.14

If a tokio::sync::oneshot channel is closed (via the
oneshot::Receiver::close method), a data race may occur if the
oneshot::Sender::send method is called while the corresponding
oneshot::Receiver is awaited or calling try_recv.

When these methods are called concurrently on a closed channel, the two halves
of the channel can concurrently access a shared memory location, resulting in a
data race. This has been observed to cause memory corruption.

Note that the race only occurs when both halves of the channel are used
after the Receiver half has called close. Code where close is not used, or where the
Receiver is not awaited and try_recv is not called after calling close,
is not affected.

See tokio#4225 for more details.

See advisory page for additional details.

We use vulnerable tokio versions directly (tracking the tower-lsp version) and via tower-lsp. Although tower-lsp uses oneshot channels, it never uses close on the receiver, so we "should" ™️ be safe here.

this is resolved in troy