Feature request: add support for jumping to json node by specific path.

[wufeng87]

Say I already open the json I need to view, and I got the path I want to jump to from another colleague, and I want to jump to this path without reload my page.

It's more effective than using the search bar to search and navigate.

[Suven-p]

Can I work on this?

[ericallam]

Sure, go for it!

[matt-aitken]

@Suven-p you'll see we’re using paths a lot in the code already to navigate. Using https://www.npmjs.com/package/@jsonhero/path

[Suven-p]

I thought of having the PathBarLink have text mode and gui mode.
Go into text mode by double clicking path bar.
When focus moves out of path bar switch directory and switch back to GUI mode.

Something like these

Would that work?

[matt-aitken]

I like the idea of it being edited in the path bar. The only issue with double click is it seems a shame that such a useful feature is hidden behind a hidden gesture. What if we had an edit button to the right of the path bar that turns it into a textfield like you suggested. When in text editing mode that button turns into a tick to commit? (Return/Enter on the keyboard would also commit). What do you think?

…

On 27 Sep 2022, at 09:29, Suven-p ***@***.***> wrote: I thought of having the PathBarLink <https://github.com/apihero-run/jsonhero-web/blob/478f41f45ec7ee468442880135b6ca40e098fb30/app/components/PathBar.tsx#L31> have text mode and gui mode. Go into text mode by double clicking path bar. When focus moves out of path bar switch directory and switch back to GUI mode. Something like these <https://user-images.githubusercontent.com/47393058/192472965-241a1c93-0ffd-4b5d-98b8-201be4508e6a.png> <https://user-images.githubusercontent.com/47393058/192473090-24e4068c-0458-44b7-8072-d4f5eb688755.png> Would that work? — Reply to this email directly, view it on GitHub <#100 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACREVUVJEEJ5SO4C3ICLOILWAKWAFANCNFSM6AAAAAAQS3OPNQ>. You are receiving this because you commented.

[Suven-p]

Yes that makes sense. Would it be ok if I make the PR in October for hacktoberfest? aiming for October first :)

[matt-aitken]

That sounds great 👍

…

On 27 Sep 2022, at 09:52, Suven-p ***@***.***> wrote: Yes that makes sense. Would it be ok if I make the PR in October for hacktoberfest? aiming for October first :) — Reply to this email directly, view it on GitHub <#100 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACREVUXMM7ZDQNPOQDVL2ODWAKYWFANCNFSM6AAAAAAQS3OPNQ>. You are receiving this because you commented.

[Suven-p]

Deployed to https://json.nevus.workers.dev/ from Suven-p@1b16beb

[ericallam]

This looks great! Would love a PR when you get a chance