Test failure when connector implements Connector::getInitialMemoryRequirement
Opened this issue · 0 comments
shlomi-alfasi commented
When a connector implements this function and return a value larger than 0 the following assertion fail.
this happens because the memory assertion is done before the node shuts down and releases its reserved memory
2024-11-26T00:40:52.779-0600 INFO main io.trino.testing.containers.junit.ReportLeakedContainers DockerClientFactory not initialized, so there should be no leaked containers, skipping the check
java.lang.AssertionError:
Expected memory reservation on server_0(worker)to be 0 but was 1048576; detailed memory usage:
at io.trino.testing.AbstractTestQueryFramework.assertMemoryPoolReleased(AbstractTestQueryFramework.java:162)
at io.trino.testing.AbstractTestQueryFramework.lambda$checkQueryMemoryReleased$0(AbstractTestQueryFramework.java:147)
at io.trino.testing.assertions.Assert.assertEventually(Assert.java:43)
at io.trino.testing.AbstractTestQueryFramework.lambda$checkQueryMemoryReleased$1(AbstractTestQueryFramework.java:140)
at java.base/java.util.Optional.ifPresent(Optional.java:178)
at io.trino.testing.AbstractTestQueryFramework.checkQueryMemoryReleased(AbstractTestQueryFramework.java:140)
at io.trino.testing.AbstractTestQueryFramework.close(AbstractTestQueryFramework.java:126)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
at java.base/java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1117)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)