tro3/ThreadPools.jl

Don't export `results`?

Closed this issue · 4 comments

IanButterworth commented

I typically use using and was surprised to see that ThreadPools exports results which is a very generic name to export.

Just a suggestion, but perhaps if that needs to be exported, it could have a less generic name?

tro3 commented

Actually, that just looks like a cut & paste issue or something. Zero reason to export that. I will fix.

tro3 commented

Oh, that is an actual function. You're right - it is too generic - changing it to poolresults will be API-breaking. But so be it.

  • 👍1
IanButterworth commented

Thanks!

  • 👍1
tro3 commented

Rev 2.0.0 is making its way through the system