warns about integration test stage in Jenkinsfile, then ignores
ochko opened this issue · 0 comments
ochko commented
It has defect both false positive and false negative way.
False positive: It warns that Jenkinsfile is not identical when it shouldn't be identical.
False negative: It says nothing when integration test stage is commented out, but there is an integration test in tests/integration
directory.
Desired states are:
Jenkinsfile has integration test stage | Integration test in tests/integration directory | qansible qa |
---|---|---|
yes | yes | pass |
no | no | pass |
yes | no | fail |
no | yes | fail |
qansible qa
[warn] File, Jenkinsfile is not identical
--- .../Jenkinsfile 2017-02-08 12:33:13.000000000 +0900
+++ .../Jenkinsfile 2017-02-08 12:29:59.000000000 +0900
@@ -37,7 +37,6 @@
} finally {
sh 'bundle exec kitchen destroy'
}
-/* if you have integration tests, uncomment the stage below
stage 'integration'
try {
// use native rake instead of bundle exec rake
@@ -50,7 +49,6 @@
} finally {
sh 'rake clean'
}
-*/
stage 'Notify'
notifyBuild(currentBuild.result)
step([$class: 'GitHubCommitNotifier', resultOnFailure: 'FAILURE'])
[notice] You may ignore warnings if integration test stage is uncommented
INFO Number of warnings: 1
INFO Successfully finished.