trufflesuite/drizzle-legacy

Drizzle cache does not clear error message

rawfalafel opened this issue · 3 comments

rawfalafel commented

Steps to reproduce:

  1. Call cacheCall on a contract method that reverts
  2. Wait until drizzleState contains error message in cache
  3. Update contract state so that the method doesn't revert
  4. Let cacheCall execute again. This time no revert.

Expected: cache doesn't contain contain error message
Actual: cache contains error message

Here's my fix which also handles the inverse case (clearing value when a method suddenly reverts): UMAprotocol/drizzle@4581c3d

cds-amal commented

Thanks @rawfalafel! Can you submit a PR?

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rawfalafel commented

Bump. I opened a PR for this issue that hasn’t been addressed. Thanks :)