11 issues in Dockerfile

[emanuelb]

1. sudo not needed

there is no need to install & use sudo in container as it's run by root inside container.

sudo is installed in:

trusteeWallet/docker/Dockerfile.androidprebuild

Line 11 in 55f72dc

DEBIAN_FRONTEND=noninteractive apt-get -qq -y install sudo build-essential openjdk-8-jdk git curl sudo pigz unzip python3-distutils python3-apt && \

and used in:

trusteeWallet/docker/Dockerfile.androidprebuild

Line 13 in 55f72dc

sudo dpkg-reconfigure --frontend noninteractive tzdata && date && \

trusteeWallet/docker/Dockerfile.androidprebuild

Line 23 in 55f72dc

curl -sL https://deb.nodesource.com/setup_14.x | sudo -E bash - && \

trusteeWallet/docker/Dockerfile.androidprebuild

Line 29 in 55f72dc

RUN echo "JAVA_HOME=$(which java)" | sudo tee -a /etc/environment && \

2. Old bundletool

trusteeWallet/docker/Dockerfile.androidprebuild

Line 21 in 55f72dc

curl -sL -o bundletool.jar https://github.com/google/bundletool/releases/download/1.5.0/bundletool-all-1.5.0.jar && \

latest version is 1.7.0: https://github.com/google/bundletool/releases/download/1.7.0/bundletool-all-1.7.0.jar

3. old command line tools
   

   trusteeWallet/docker/Dockerfile.androidprebuild

   Line 47 in 55f72dc

   curl -s -o commandlinetools-linux.zip https://dl.google.com/android/repository/commandlinetools-linux-6858069_latest.zip && \

latest is: https://dl.google.com/android/repository/commandlinetools-linux-7302050_latest.zip
from: https://developer.android.com/studio/index.html#command-tools

4. Install python3-pip instead of using get-pip.py

trusteeWallet/docker/Dockerfile.androidprebuild

Lines 14 to 17 in 55f72dc

	curl -O https://bootstrap.pypa.io/get-pip.py && \
	python3 get-pip.py && \
	python3 -m pip install gplaycli && \
	rm -f ./get-pip.py && \

Documentation of pip installation suggest to not use git-pip when there is available package for distro:
https://pip.pypa.io/en/stable/installing/#installing-with-get-pip-py
https://pip.pypa.io/en/stable/installing/#using-linux-package-managers

The python3-pip package for ubuntu install pip.

5. Add --no-install-recommends for apt-get install commands:

adding --no-install-recommends for apt-get install commands will probably/may reduce the amount of packages installed (then the package list may need to be increased with some required dependencies for the usage which are part of the recommended list, like for example ca-certificates package)

trusteeWallet/docker/Dockerfile.androidprebuild

Line 11 in 55f72dc

DEBIAN_FRONTEND=noninteractive apt-get -qq -y install sudo build-essential openjdk-8-jdk git curl sudo pigz unzip python3-distutils python3-apt && \

trusteeWallet/docker/Dockerfile.androidprebuild

Line 24 in 55f72dc

apt-get -y install nodejs && \

6. Combine RUN

trusteeWallet/docker/Dockerfile.verifyandroidbuild

Lines 23 to 30 in 55f72dc

	RUN cd ./src/android && \
	touch local.properties && \
	echo sdk.dir=/${WDIR}/androidsdk/ >> ./local.properties && \
	echo ndk.dir=/${WDIR}/androidsdk/ndk/21.4.7075529 >> ./local.properties
	RUN cd ./npm && tar -xf node_modules.tar.gz && \
	mv --force -v ./${WDIR}/src/node_modules ../src/ && \
	rm -f ./node_modules.tar.gz

trusteeWallet/docker/Dockerfile.androidprebuild

Lines 29 to 34 in 55f72dc

	RUN echo "JAVA_HOME=$(which java)" | sudo tee -a /etc/environment && \
	. /etc/environment
	RUN mkdir -p /${WDIR}/npm && \
	mkdir -p /${WDIR}/src && \
	mkdir -p /${WDIR}/androidsdk/cmdline-tools/latest

each RUN command create layer, it's better to use less RUN commands instead, such as:

RUN set -ex; \
         command1; \
         command2;

7. Use COPY instead of ADD

trusteeWallet/docker/Dockerfile.androidprebuild

Line 36 in 55f72dc

ADD package.json ./src

8. Use valid values for BUILD_NUMBER & COMMIT_SHA :
   

   trusteeWallet/docker/Dockerfile.verifyandroidbuild

   Lines 3 to 4 in 55f72dc

   	ARG BUILD_NUMBER=1
   	ARG COMMIT_SHA=12345678

   
   as example, add comment before it to change them, as currently the values are invalid (not sha commit)

9. old cmake
   

   trusteeWallet/docker/Dockerfile.verifyandroidbuild

   Line 21 in 55f72dc

   sdkmanager --install "cmake;3.6.4111459"

newest from android sdk tools: 3.18.1

10. use npm ci
    

    trusteeWallet/docker/Dockerfile.androidprebuild

    Line 39 in 55f72dc

    npm install --quiet --no-progress && \

npm ci is needed for reproducible package versions installation.

11. Running as root in container

Currently every command is run under root in the container, it's better to run whats possible under regular user instead.
Use USER directive to change to user created with command such as useradd -ms /bin/bash appuser