trycourier/courier-go

ListSubscribe returns an error on 204 status codes

Closed this issue · 2 comments

vince-makelog commented

Expected Behavior

Should not return an error, unless the status code is >=4xx

Actual Behavior

The library https://github.com/trycourier/courier-go/blob/master/v2/api.go#L112 returns an error for anything that's not a 200.

Steps to Reproduce the Problem

  1. Use ListSubscribe
  2. API returns 204
  3. Library returns an error

Specifications

  • Version: v2
tk26 commented

@vince-makelog We will take a look at this issue and get back soon. Thanks for filing.

tk26 commented

@vince-makelog we've fixed the issue. Thanks for the feedback.