Proposal: Extract Laravel implementation to a separate repository
slashequip opened this issue · 5 comments
I would like to propose the the Laravel code is removed from this repository and moved to it's own separate repository.
trycourier/courier-php
- This allows this package to purely support the PHP implementation.
- Folks installing the package may not need the the additional code, nor should it be a requirement for them.
- The current Laravel code is not tested, adding tests would add complexity to this package.
- IMO, the current Laravel code is well below par when it comes to what the Laravel community expect from a package.
- Increasing Laravel support here would make it harder for others, unfamiliar with Laravel, to contribute, and understand.
trycourier/courier-laravel
- Allows improvements to the existing code in a dedicated and well tested environment.
- Would pull in this package so core functionality is still provided here.
- The aforementioned environment would allow us to more easily add some more features. I have been thinking about adding the ability to have Courier as a custom notification channel, allowing integration with Laravel's first-party notification system.
Imagine;
$user->notify(new InvoicePaid($invoice));
// Triggers a sendNotification() call to courier with the user reference and additional profile data etc. 🤤
Feel free to tell me to stop 😂
I'll look to put together an example repository together under my GitHub account, see what you think and we can discuss moving forward 😄
@slashequip apologies I haven't been able to go deep on this proposal just yet. Will def get back later today :)
Don't worry about it, began to put a few things together here; https://github.com/slashequip/courier-laravel/ to replicate existing features and I'll begin to play around with the idea of this notification.
Even if this isn't something Courier wants to own/maintain the package should have merit on it's own anyway.
sounds good, thanks @slashequip 🥇