tsantalis/RefactoringMiner

nonMappedLeavesT1/nonMappedLeavesT2 lists present mapped elements.

Closed this issue · 4 comments

xuyisen commented

Commit link

Problem

Professor Nikalaos,
When I used the latest version of RefactoringMiner to detect pure refactoring of gson project, I found that several attributes of bodyMapper may conflict. nonMappedLeavesT1 and nonMappedLeavesT2 should store statements without mapping relationship, but I found that mappings already have three leave statements, which appeared again in nonMappedLeavesT1 and nonMappedLeavesT2. This caused problems when I analyzed pure operation. Is this a problem?
QQ_1731099963981
QQ_1731100036171

Yisen Xu from course SOEN6491

tsantalis commented

@xuyisen
These are nested lambda expressions, within matched statements.

  • ❤️1
xuyisen commented

Thank you, Professor. I got it. Is it possible to map these lambda expressions as well, i.e. move them to the mappings property? Because they do look the same in terms of expression.

tsantalis commented

@xuyisen
I fixed it with my last commit. You should not have nonMappedLeaves now. Please confirm.

  • 👍2
xuyisen commented

Thank you, Professor. I pulled the latest code, re-ran the program on this commit, and now it works fine.