[BUG] A char is treated as a pointer in _NvdDialogBox

[rj45]

nvdialog/src/impl/nvdialog_typeimpl.h

Lines 37 to 39 in c35acb9

	char *msg;
	char *content;
	char *accept_label, reject_label;

These three lines should be const char *, and reject_label is only a char wide, it's missing the * to make it a pointer. Setting the field will cause compiler errors/warnings and/or overwrite the padding/other fields of the struct.

Fixing is not urgent, I have the fixes in my local copy. Just thought you would want to know about it.

If you want these bug reports as PRs instead, let me know. Also let me know if you want one big PR or several small ones.

[tseli0s]

These three lines should be const char *

Not necessarily, I avoid it because of unnecessary warnings related to modifying const pointers. Yeah I could disable the warnings but maybe they'll come in handy somewhere else.

Also let me know if you want one big PR or several small ones.

small ones are always better for organization, in case one PR does something it shouldn't do we can reverse it without reversing the rest