Snitch doesn't support repositories cloned over SSH with alias

Question

Snitch doesn't support repositories cloned over SSH with alias

mateossh opened this issue 5 years ago · 10 comments

mateossh commented 5 years ago

Screenshot for better understanding

gh:.... is SSH alias in git config

Answer 1 · 2019-09-16T19:28:08.000Z

adding alias key to .ini files
get URL the same way we get list of files to be checked? (strip the user part or just add it to regex)

Answer 2 · 2019-09-16T19:34:35.000Z

@mfocko It would be cool if it just worked without any additional configuration. Maybe we can look at the git config for aliases?

Answer 3 · 2019-09-16T19:36:53.000Z

As far as I remember Git config is also ini file. I will try to solve this issue when I find some free time.

Answer 4 · 2019-09-16T19:37:57.000Z

@rexim maybe the second option then... we just run the first command from screenshot,,, it drops the need to look for .git in program and also processing the config as ini file
@mateossh it keeps alias in git config, that's why you got github.com with get-url and snitch failed (it parses .git/config)

EDIT:
@mateossh the git command probably resolves the alias before printing out the url

Answer 5 · 2019-09-17T21:19:08.000Z

Checked it on archLinux install... It doesn't resolve aliases for me, so I'm bit confused about it

@rexim So maybe going with parsing the ssh config?

Answer 6 · 2019-09-17T22:58:23.000Z

@mfocko but the description says it's in the git config

gh:.... is SSH alias in git config

I'm confused. Where is the alias? In ssh config or git config? :)

Answer 7 · 2019-09-18T07:07:03.000Z

@rexim You configure "hosts" in ssh config, assign hostname, auth, etc. And git just uses it :D so .git/config contains only alias and ssh/config both alias and real hostname

Edit:
However if we use git remote get-url origin, we don't need to locate .git and parse it, also it could probably help with #145?

Answer 8 · 2019-09-18T11:53:46.000Z

All of that sounds over complicated. Let's solve this problem via #146

Answer 9 · 2019-09-18T12:06:14.000Z

@rexim So you want to specify the host directly in .snitch.yaml if I understand correctly?
Also if you specify it in config file, you have no need to locate and parse .git/config, which seems nice, just need to check if there are credentials for the host.

Answer 10 · 2019-10-01T22:36:07.000Z

@mfocko @rexim You can create alias in two ways:

In git config -> ~/.gitconfig
In ssh config -> ~/.ssh/config

I created PR, please take a look at #160