tsoding/snitch

Keep repository in IssueAPI structure?

mfocko opened this issue · 4 comments

mfocko commented

Since the repository is matched against host assigned to token, there is no particular reason to keep it outside of credentials?

Only place it's used (outside the GET and POST against service API) is:

  1. printing issue link (can be extracted to something like getRepoAddress)
  2. printing detected project (can be resolved same way as issue link)
rexim commented

@mfocko yeah, I had exactly the same thoughts while reviewing #154. I like that idea. Maybe go even further and rename IssueAPI to Repo? What do you think?

mfocko commented

@rexim Sounds OK, I'll resolve it later

rexim commented

@mfocko #154 is already merged btw. Feel free to make a separate PR.

rexim commented

Resolved by #158 (comment)