tsroten/dragonmapper

Wrong to_pinyin

subhero24 opened this issue · 7 comments

subhero24 commented 
print hanzi.to_pinyin(u'绿')

outputs l̈ù
but should be lǜ

mthewissen commented

Same goes for 女 and other words containing a 'u' that both has an intonation and umlaut on it

subhero24 commented

Pinyin of 女 was already fixed few months ago. See #10.

mthewissen commented

Oh my bad. I wasn't using the develop branch yet. Seems related though.

ham1 commented

Looking at the data, quite a few characters map to l̈ù. Is this always incorrect?
Should 绿 only be lǜ?

虑 l̈ù/bì/lǜ
綠 l̈ù/lǜ
律 l̈ù/lǜ
绿 l̈ù/lǜ
慮 l̈ù/lǜ/lǘ
率 l̈ù/shuài/lǜ/lüe

Also, is l̈ú ever valid? e.g.

驴 l̈ú/lǘ
驢 l̈ú/lǘ
铝 l̈ǔ/lǚ
缕 l̈ǔ/lǚ
旅 l̈ǔ/lǚ
縷 l̈ǔ/lǚ
鋁 l̈ǔ/lǜ/lǚ
subhero24 commented

I'm no expert on this, but I think l̈ù is always incorrect.
I have never seen the umlaut on any other letter but 'u' in pinyin.

tsroten commented

@BrunoVanDamme Thanks for reporting this! I've gone ahead and fixed it. I'll have a new release out shortly.

tsroten commented

Ok, this is now on PyPi. Thanks again!

  • 👍1