Incorrect logic in commit regarding MB/MiB
Closed this issue · 3 comments
Describe the bug
Backwards logic in commit 4b42728
MB stands for "Megabyte", which is a power of 10, MiB stands for "Mebibyte" which is a power of 2. That is to say, the original code was correct and the person who made this change was incorrect.
** Versions **
[ ] Tested on latest stable version
[ ] Pre-release only bug
To Reproduce
Read the commit history and then read a wikipedia article about mebibytes.
Expected behavior
People not asserting things that are demonstrably false.
https://en.wikipedia.org/wiki/Byte#Multiple-byte_units
Thanks, will be fixed in a future build.
This was highlighted and corrected in the now missing / disconnected commit f12f90f
From #74
On this note, it should always have been using the measurement (MiB) and number for bytes (power of 8), you always download in bytes as in powers of 8 because that's now networking hardware/firmware is built, so that change was correct to use binary powers just the text display was incorrect but was then fixed by the now disconnected commit.
Thanks for pointing this out. I missed that commit as I couldn't merge it clean, so I refactored it a bit to resemble the original one.
Cheers!