Provide storage interface
Closed this issue · 3 comments
There should be a storage interface that should be implemented and passed into PyPump which will allow PyPump get and store data. This should eventually make things like .get_registration and passing in the key and secret redundant.
I suggest a storage like object which looks/works like a dictionary, I'd have something similar to what's in https://github.com/Aeva/waterworks/blob/master/waterworks/store.py which looks like a dictionary but writes to disk too.
This should fix the remaining issues with #89
This has been started and exists in the "store" branch. It currently does work though there is still some things to do, e.g.
- Unit tests to cover store
- Documentation
I have written some documentation on the store. This really could do with some more testing before being put into master. The other existing documentation needs to be updated in regard to the storage class too.
The unit tests have been updated so that they work with the store class but there hasn't been any tests written that verify specifics about the storage class that needs to be done too.
This has been completed.