ttacon/libphonenumber

How to update the rules to match isoCountry and number type

Opened this issue · 3 comments

fabriziomoscon commented

Hi @ttacon,
I have been using the library for few months and it works great, but sometimes the country and number type are not guessed correctly.
For example there are few exceptions I noticed for UK and Greece.
In UK some numbers country must belong to the Channel Islands so for example

countryTypeException{
			pattern:        "^\\+447781.*",
			isoCountryCode: "GU",
			numType:        "mobile",
			description:    "Sure mobile phones and pagers",
		}

And I found a special case for old greek pager that at the moment returns MOBILE.

It would be great to understand what is the process to update these rules and also import new updates from the original library you ported

Thanks much appreciated

nicpottier commented

Just a heads up that we've started more active development on a fork of this library here: https://github.com/nyaruka/phonenumbers

Since ttacon seemed a bit busy. We've built a tool to update the metadata so curious if you see the same issues with our fork as it is using the current Google definitions.

  • 👍1
spacetourist commented

well that's a bustling community.. sticking with @ttacon 👍

ttacon commented

@fabriziomoscon sorry for the very late reply! I'll add some unit tests later to allow me to dig into this.