Add godeps.json

[steelbrain]

It'll help users not to have to figure out the dependencies on their own and will allow package managers like glide to do their job properly

[17twenty]

Why can't you just use go get -u github.com/ttacon/libphonenumber?

What would a godeps.json add?

[steelbrain]

@17twenty I did try go get, but this package depends on external dependencies that are not automatically installed by go get. Adding a Godeps file would indicate the consumers which dependencies need to be installed

[17twenty]

I couldn't repeat that issue. The issue with godeps is it links to a package manager that may or may not be wanted as a dependency

…

On 19 Apr 2017 6:52 pm, "Steel Brain" ***@***.***> wrote: @17twenty <https://github.com/17twenty> I did try go get, but this package depends on external dependencies that are not automatically installed by go get. Adding a Godeps file would indicate the consumers which dependencies need to be installed — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#48 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXJKHT7ZIiiB9OEKIIzEv8h5bm1TB81ks5rxcs8gaJpZM4L9cXr> .

[steelbrain]

That's not entirely true, when you add Godeps state file, you are not actually tying this package to a package manager at all. It saves current state of dependencies of this package only, it'll only be used if the person downloading uses a package manager (almost all package managers eg. Glide, godep support this file), if they don't go-get will work just as fine as it does now.

[ttacon]

Feel free to open a PR addressing this @steelbrain!

[ttacon]

Hi @steelbrain, this project is now using dep - let me know if that solves your issue!