tteck/Proxmox

Typo in URL "$var_install.sh" vs. "$var-install.sh"

Grantelbert0815 opened this issue · 1 comments

Please verify that you have read and understood the guidelines.

yes

A clear and concise description of the issue.

There is a Typo _ vs. - here

https://github.com/tteck/Proxmox/blob/6fbb8ab4a218638ca1c8c01f12ab0657c0f4a39b/misc/build.func#L636C51-L636C127

This URL doesn't exist.
https://raw.githubusercontent.com/tteck/Proxmox/main/install/$var_install.sh

Should be replaced by
https://raw.githubusercontent.com/tteck/Proxmox/main/install/$var-install.sh

What settings are you currently utilizing?

Default Settings

Which Linux distribution are you employing?

Alpine

If relevant, including screenshots or a code block can be helpful in clarifying the issue.

lxc-attach -n "$CTID" -- bash -c "$(wget -qLO - https://raw.githubusercontent.com/tteck/Proxmox/main/install/$var_install.sh)" || exit

Please provide detailed steps to reproduce the issue.

No response

I don't think this is an error because var_install is just a variable and is replaced with ${NSAPP}-install.
NSAPP-install can be e.g. “mqtt” -> mqtt-install
which means that https://raw.githubusercontent.com/tteck/Proxmox/main/install/mqtt-install.sh is then called

variables() {
NSAPP=$(echo ${APP,,} | tr -d ' ') # This function sets the NSAPP variable by converting the value of the APP variable to lowercase and removing any spaces.
var_install="${NSAPP}-install" # sets the var_install variable by appending "-install" to the value of NSAPP.
INTEGER='^[0-9]+([.][0-9]+)?$' # it defines the INTEGER regular expression pattern.