Question about concatenation in extract_sub_scores function.

Hi Théo,

I wonder if this line

Line 88 in 61fa3f6

    
           res = Result(res.preds[idxs], res.true_vals[idxs], res.ranks[np.concatenate((idxs,idxs))], res.raw_ranks[np.concatenate((idxs,idxs))])

should be "res = Result(res.preds[idxs], res.true_vals[idxs], res.ranks[np.concatenate((idxs, len(idxs)+idxs))], res.raw_ranks[np.concatenate((idxs, len(idxs)+idxs))])". That is, add len(idxs) to the concatenation.

Thanks a lot.

Indeed it should be this, will fix asap, thanks!

Actually no! Because idxs is a boolean array that has the same size as res.ranks, and is equal to True at the indexes to extract, so the correct code is indeed np.concatenate((idxs,idxs)).

Sorry for the latency and the wrong first reply :/

Yes, it's my fault. Thanks for your patience!