In contrast to less: mdless doesn't adapt to changing view port of terminal

Question

In contrast to less: mdless doesn't adapt to changing view port of terminal

Closed this issue 7 months ago · 21 comments

As seen in the two screenshots less uses the full width of the terminal when the viewport is switched from portrait to landscape and mdless keeps the portrait formatting.

Thanks for a great app!

Unfortunately I cannot attach screenshots in GitHub mobile app.

Answer 1 · 2023-09-15T00:51:34.000Z

Could you please fix this issue for gem package? It's annoying and doesn't offer "a replacement for less".

Answer 2 · 2023-09-15T12:39:20.000Z

mdless calculates its line wrapping and code formatting based on the width of the screen at the time the command is run. There is no way to output what it does in a way that will wrap if the screen width is changed.

Answer 3 · 2023-09-15T20:46:21.000Z

Hello Brett, Thank you for your answer and your commitment! It's exactly what less does: it respects view port changes of the terminal on the fly. Please reconsider! Bye Gerrit P. S. Screenshots attached Brett Terpstra ***@***.***> schrieb am Fr., 15. Sept. 2023, 14:39:

…

mdless calculates its line wrapping and code formatting based on the width of the screen at the time the command is run. There is no way to output what it does in a way that will wrap if the screen width is changed. — Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNARBO524YFJODCOTALU3X2REAFANCNFSM6AAAAAA3KDRVKI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Answer 4 · 2023-09-15T21:03:45.000Z

leder11011 commented 10 months ago

Answer 5 · 2023-09-29T20:08:35.000Z

Bump @ttscoff

Answer 6 · 2023-12-04T15:20:09.000Z

thank you for version 2.1.13!

Unfortunately I get a runtime error on Android termux, which was working fine on the previous version 1.0.37

Error is as follows:
console.rb:778:in '*': negative argument (Argument Error)

Please let me know if you need a stacktrace - I can send a screenshot, copy&pasta is a bit difficult on Android smartphone...

Answer 7 · 2023-12-04T15:25:02.000Z

https://photos.app.goo.gl/82WxiKzHutq3KQdcA

Answer 8 · 2023-12-04T16:21:12.000Z

I believe this is fixed (current version 2.1.17).

…

On 4 Dec 2023, at 9:20, leder11011 wrote: thank you for version 2.1.13! Unfortunately I get a runtime error on Android termux, which was working fine on the previous version 1.0.37 Error is as follows: console.rb:778:in '*': negative argument (Argument Error) Please let me know if you need a stacktrace - I can send a screenshot, copy&pasta is a bit difficult on Android smartphone... -- Reply to this email directly or view it on GitHub: #88 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

Answer 9 · 2023-12-04T19:04:21.000Z

Thank you for version 2.1.23

I have a regression now:

Opening mdless already in landscape mode uses the landscape width only partly, cp. Screenshot

Answer 10 · 2023-12-04T23:00:20.000Z

Is there a width setting hardcoded in ~/.config/mdless/config.yml? It may have stored a current column width and then defaulted to it. If that’s the case I should remove that from automatic saving, so let me know. Thanks, Brett

…

On Dec 4, 2023 at 1:04 PM -0600, leder11011 ***@***.***>, wrote: Thank you for version 2.1.23 I have a regression now: Opening mdless already in landscape mode uses the landscape width only partly, cp. Screenshot Screenshot_20231204-195932.png (view on web) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Answer 11 · 2023-12-05T07:50:41.000Z

Hello Brett,

deleting the line :width: from config.yml did the trick! Please remove it from auto saving, too.

Best regards
Gerrit

Answer 12 · 2023-12-05T11:35:37.000Z

I will delete, but it will mean any time a user wants to set a permanent width setting they'll have to manually include the :width: key, and running --update-theme will delete it. I'll just document it well.

…

-Brett

On 5 Dec 2023, at 1:50, leder11011 wrote: Hello Brett, deleting the line `:width:` from `config.yml` did the trick! Please remove it from auto saving, too. Best regards Gerrit -- Reply to this email directly or view it on GitHub: #88 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

Answer 13 · 2023-12-05T13:20:57.000Z

Thank you!

2.1.25 is breaking with runtime error

Answer 14 · 2023-12-05T13:43:27.000Z

Try 2.1.26. If that doesn't fix it, please attach a sample file that can replicate the error for you.

…

-Brett

On 5 Dec 2023, at 7:21, leder11011 wrote: Thank you! 2.1.25 is breaking with runtime error ![Screenshot_20231205-141907.png](https://github.com/ttscoff/mdless/assets/3330116/be9aa3f8-7e41-49e6-b470-14b558fca651) -- Reply to this email directly or view it on GitHub: #88 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

Answer 15 · 2023-12-05T14:04:27.000Z

Yes 2.1.26 fixed the error.

As you can see in the screenshot there are early line breaks:

in the table header before "email"
in between "79" and "days"
width is set to: 116

Answer 16 · 2023-12-05T14:11:57.000Z

I’m going to put some more time into table formatting soon. Thanks, Brett

…

On Dec 5, 2023 at 8:04 AM -0600, leder11011 ***@***.***>, wrote: Yes 2.1.26 fixed the error. As you can see in the screenshot there are early line breaks: • in the table header before "email" • in between "79" and "days" • width is set to: 116 Screenshot_20231205-150010.png (view on web) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Answer 17 · 2023-12-05T14:12:14.000Z

leder11011 commented 8 months ago

Answer 18 · 2023-12-06T10:03:41.000Z

Thank you for 2.1.28

The table headers and line break before "days" are fixed now.

But every line that had a line break before "days" has an extra empty line in the next row.

Can you please have a look?

Answer 19 · 2023-12-06T18:45:41.000Z

Please provide the document containing the table you're working with. I haven't touched the wrapping functions at all yet, so any change you're seeing is unintentional.

Answer 20 · 2023-12-06T21:03:03.000Z

Please have a look...

Answer 21 · 2024-01-13T10:56:36.000Z

Thank you @ttscoff !

the configuration of the screenwidth fixes this for me now! It is not calculated on the fly on my smartphone, but what the heck: I only use app Termux in landscape only! So I am more than satisfied with your app mdless! Keep up the good faith!

Gerrit