ttu/ruuvitag-sensor

Release version 3.0

ttu opened this issue ยท 12 comments

ttu commented

Tasks before creating a release:

  • Bleak as default adapter for Linux
    •  Install Bleak: #244
    •  Set bleak as default adapter: #249
    • Update verification script: #248
  • Drop support for Python 3.7 & 3.8
  • Update examples
    • Remove setting bleak in async examples and set bluez in sync examples

I created a commit for item two in the above list, it can be found at terop@757b441.
@ttu please take a look in case I missed something and if something should be change or improved.

ttu commented

Thanks, commit looks good. I will leave comments if something comes to mind that is missing.

I was thinking that we should also drop support for 3.8 with this release. Its end of life is in October 2024, so by the time of the release, it won't be that far away. Based on the PyPI stats, it is not very widely used.

So is the plan to wait for October to make the release or also remove 3.8 support before official support ends (and not wait for October)?

ttu commented

There is no need to wait for the official support to end. Based on current pypistats, most installations are from Python 3.10 and above.

There will be a final release for v2 with the fixes that have not yet been released, and after that, we can begin preparations for the v3 release.

Okay. I could then add another commit for the removal of Python 3.8.

I rebased my branch from master and now it contains the following commits.
Python 3.7 support removal: terop@b3658eb
Python 3.8 support removal: terop@0c94840

@ttu Could you kindly check the above commits?

ttu commented

@terop sorry again for the delay. I think those commits already had pretty much all required changes. I found few mentions about default adapters that should be changed to Bleak, but after that I think those are good ๐Ÿ‘

Thanks for the comments @ttu.
I fixed them as best I could and rebased the branch so now the commits are as follows:
Python 3.7 support removal: terop@133ee50
Python 3.8 support removal: terop@ec28465

ttu commented

@terop sorry for the delay again. I finally had some time to get back to this.

I created two PRs; selecting default adapter and updated verification script. Could you create a PR for dropping Python 3.7 & 3.8 support?

I will still go through the functionality and test this with Linux to make sure we are not missing anything.

@ttu Sure and sorry for the delay.

Please find a PR to drop Python 3.7 and 3.8 at #251.