Add ArgumentParser to SAGE
jzelenjak opened this issue · 1 comments
jzelenjak commented
Description
Currently, parsing of the input arguments is happening manually, which is a bit cumbersome.
Furthermore, another optional parameter has to be added for the dataset name. This is needed because some if-checks in the code are CPTC-specific (see issue #24).
Proposed solution
- Replace the manual parsing with
ArgumentParser
(similar to SECLEDS) - Add one more option:
dataset_name
(options = {"cptc", "other"}, default value = "other") - Optionally, add another optional parameter to not remove the dot files
- Update the
docker
branch accordingly (only the new options have to be added to thescript.sh
andinput.ini
files, no other changes are necessary, i.e. theinput.ini
file remains only on thedocker
branch,spdfa-config.ini
remains only on themain
branch, argument parsing remains in thesage.py
, with the exception that default values of optional parameters will be added to thescript.sh
file). - Update the documentation for the
main
anddocker
branches
azqanadeem commented
About point 3: Update the DOCKER flag value with the one parsed from the CMD arguments. The Default value of True(?) remains.