tur-nr/polymer-redux

Merge polymer-2 into master

tur-nr opened this issue · 6 comments

tur-nr commented
  • Create develop/v0 branch for Polymer v1.x
  • Merge polymer-2 branch into master
  • Release new major version
abdonrd commented

How is the status of this?

Thanks in advance! 👏

tur-nr commented

Trying to resolve some breaking changes when updating dependencies and a few housekeeping stuff left to do. Hopefully not too long :)

  • 👍5
ronnyroeller commented

@tur-nr Is there anything we can help with upgrading polymer-redux to Polymer 2?

tur-nr commented

@ronnyroeller thanks for offering your help.

So here are the two failures I'm getting, maybe you could help.

Polymer Lint
polymer lint is returning warning which won't pass the tests

index.js(149,34) warning [unknown-superclass] - Unable to resolve superclass parent

Documenting the block of code with @polymerMixin or @polymerMixinClass does not prevail.

Firefox Fails

Firefox hangs in the tests. WCT opens firefox but seems like the tests are never loaded or run so the timeout hits failing them.

tur-nr commented

So I managed to fix the linting issue, turns out the @polymerMixin was placed on the wrong block of code so the analyzer wasn't picking it up.

Still no luck on the Firefox hang, but master is currently not testing Firefox through CI so I may go ahead with the merge.

tur-nr commented

v1.0.0 released.