Invalid module imports don't work as expected
turbobabr opened this issue · 4 comments
It seems that MSPlugin.scriptWithExpandedImports:path: method resolves paths differently than my implementation. Here is the result I get when running an old plugin that actually works in sketch:
Should turn off the whole imports checking module and revisit it later.
Not sure if it’s is related to this topic, but plugins that have imports don’t work anymore as soon as the console did open. Dev Tools Console says the Script executed but nothing really happens. Log from OS X console:
24/10/14 20:56:09,223 Sketch[4733]: -[TDToken quotedString]: unrecognized selector sent to instance 0x60000185b300
24/10/14 20:56:09,223 Color Inventory (Sketch Plugin)[4733]: Caught script exception: -[TDToken quotedString]: unrecognized selector sent to instance 0x60000185b300
Holy crap! Thank you for reporting this. Will try to fix it ASAP!
Florian,
I've found a problem, and now it works like a charm! :)
Here is the proof:
The fix isn't published yet, because I have to ask a few questions to Sam about file paths resolving mechanism. I think that fix will be available tomorrow.
Great! Thanks buddy :)
On Tue, Oct 28, 2014 at 8:40 AM, Andrey Shakhmin notifications@github.com
wrote:
Florian,
I've found a problem, and now it works as a charm! :)
Here is the proof:
The fix isn't published yet, because I have to ask a few questions to Sam about file paths resolving mechanism. I think that fix will be available tomorrow.
Reply to this email directly or view it on GitHub:
#20 (comment)