turbot/steampipe-mod-gcp-compliance

2.2 Ensure that sinks are configured for all log entries - problem with multiple projects in an aggregator

Closed this issue · 3 comments

M0nsieurChat commented

Describe the bug
When using this dashboard against an aggregator returning a set of GCP projects, only the last project will return a correctly configured log sink although every other one is configured the same (using terraform)
image

I will post a MR to update the query so that it successfully works for all projects with a correctly configured sink.
image

Steampipe version (steampipe -v)
steampipe 0.20.9

Plugin version (steampipe plugin list)
gcp: 0.41.0

To reproduce
Use this dashboard against an aggregator or put multiple gcp project in the search-path

Expected behavior
For every project in the search-path (or aggregator), all projects with correctly configured log sinks should return as OK

M0nsieurChat commented

Here is the PR : #111

rajlearner17 commented

@M0nsieurChat, Thanks for using Steampipe!

Nice catch on this; I appreciate raising PR for this as well 👍

Just adding this image to track and explain how the query behaved differently. Not sure even why we might have used this string_agg. Anyways, we will go ahead and approve the PR

image
After the fix

image

misraved commented

Addressed in #111 !!

Thanks @M0nsieurChat for the fix 👍.