tutorcruncher/pydf

Consider keeping header case as given?

damienalexandre opened this issue · 1 comments

damienalexandre commented

I'm using pydf with the wkhtmltopdf "footer-text" option,
but as every parameters are lower cased in:

pydf/docker-entrypoint.py

Line 41 in 8f9ce76

config[k[4:].lower()] = v.lower()

My text content is not properly passed througt wkhtmltopdf.

I don't know if there is a reason for this lower() call on all argument values? It's ok for the key I guess.

Reproducer

curl -d '<h1>this is html</h1>' -H "pdf-footer-right: UPPERCASE [page]/[topage]" http://localhost:8000/generate.pdf > created.pdf

Result

uppercase 1/1

Expected

UPPERCASE 1/1

samuelcolvin commented

Thanks for reporting, it was probably an oversight, please create a PR to fix this.

  • 👍1