Headers' font is hardcoded?
XhmikosR opened this issue · 5 comments
h1,
h2,
h3,
h4,
h5,
h6,
.h1,
.h2,
.h3,
.h4,
.h5,
.h6 {
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
font-weight: 500;
line-height: 1.1;
color: inherit;
}
When overwriting the default font in body
, I'd expect this to be inherited for the headers too. Is there any reason for this or it's a mistake?
BTW, since normalize.css sets the default font in html
shouldn't Bootstrap set it there too? In this case you could remove "sans-serif" from your font property.
EDIT: I guess this is done on purpose after looking at type.less... Perhaps it should be set to inherit
as a default then?
inherit
would seem to be backwards-incompatible.
Can you elaborate on that?
I just noticed it by accident and I've been using Bootstrap for a long time. I can see why some people would like to have this configurable but the default should inherit the base font to make things easier...
@XhmikosR Folks may be relying on that fact that it doesn't inherit, so changing it could break folks' sites (in that the heading font might change unexpectedly). IMO, that makes such a change backwards-incompatible, and we can only make such changes in major releases (e.g. v4).
Ugh, this is a problem of CSS practicality vs LESS functionality. Some folks want the ease of use you're talking bout @XhmikosR, and others want variables for fucking everything. The variable is why this is happening I think. Setting it to inherit
might cause some problems, too. Can't recall all the changes right now.
Thanks!